fix show for RandomDevice #41233
Merged
fix show for RandomDevice #41233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
domain:randomness
simeonschaub
approved these changes
Jun 15, 2021
|
Bump. Do we want to get this in? |
|
@rfourquet Can you rebase to master? |
On Windows, this was displaying an internal buffer, and on Linux, this was showing the keyword argument `unlimited` as if it was a positional argument.
Co-authored-by: Simeon Schaub <[email protected]>
Co-authored-by: Simeon Schaub <[email protected]>
Co-authored-by: Simeon Schaub <[email protected]>
rfourquet
force-pushed
the
rf/show-randomdevice
branch
from
c62b4df
to
eabe779
Compare
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* fix show for RandomDevice On Windows, this was displaying an internal buffer, and on Linux, this was showing the keyword argument `unlimited` as if it was a positional argument. * rm spurious space Co-authored-by: Simeon Schaub <[email protected]> * Update stdlib/Random/test/runtests.jl Co-authored-by: Simeon Schaub <[email protected]> * Update stdlib/Random/test/runtests.jl Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* fix show for RandomDevice On Windows, this was displaying an internal buffer, and on Linux, this was showing the keyword argument `unlimited` as if it was a positional argument. * rm spurious space Co-authored-by: Simeon Schaub <[email protected]> * Update stdlib/Random/test/runtests.jl Co-authored-by: Simeon Schaub <[email protected]> * Update stdlib/Random/test/runtests.jl Co-authored-by: Simeon Schaub <[email protected]> Co-authored-by: Simeon Schaub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, this was displaying an internal buffer, and on Linux, this
was showing the keyword argument
unlimitedas if it was apositional argument.