Update supported data types in TOML.print docstring
#41226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also need to make the same patch to https://github.com/JuliaLang/TOML.jl |
|
Sure, will do 👍 |
jondeuce
added a commit
to jondeuce/TOML.jl
that referenced
this pull request
Jun 14, 2021
(xref pull request [#41226](JuliaLang/julia#41226) from the `julia` repo) `AbstractVector` and `AbstractString` are missing according to [this line](https://github.com/JuliaLang/julia/blob/bc3ce48636b700d153d2c84614aaea8cb8843d43/stdlib/TOML/src/print.jl#L54): ```julia const TOMLValue = Union{AbstractVector, AbstractDict, Dates.DateTime, Dates.Time, Dates.Date, Bool, Integer, AbstractFloat, AbstractString} ```
|
Needs rebase on master to fix CI I think. |
|
Okay made a mistake rebasing at first, but I think it's good now |
KristofferC
pushed a commit
to JuliaLang/TOML.jl
that referenced
this pull request
Oct 6, 2022
(xref pull request [#41226](JuliaLang/julia#41226) from the `julia` repo) `AbstractVector` and `AbstractString` are missing according to [this line](https://github.com/JuliaLang/julia/blob/bc3ce48636b700d153d2c84614aaea8cb8843d43/stdlib/TOML/src/print.jl#L54): ```julia const TOMLValue = Union{AbstractVector, AbstractDict, Dates.DateTime, Dates.Time, Dates.Date, Bool, Integer, AbstractFloat, AbstractString} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractVectorandAbstractStringare missing according to this line: