Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bump the Statistics stdlib from 4b3ef9a to 54f9b0d #41165

Merged
merged 1 commit into from
Jun 10, 2021
Merged

🤖 Bump the Statistics stdlib from 4b3ef9a to 54f9b0d #41165

merged 1 commit into from
Jun 10, 2021

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: Statistics
Branch: master
Old commit: 4b3ef9a
New commit: 54f9b0d
Bump invoked by: @DilumAluthge

$ git log --oneline 4b3ef9a..54f9b0d
54f9b0d CI: Standardize the workflow for testing and changing the UUID (#78)
ba24318 Fix detection of NaN in median() (#73)
55d93f7 Fix NaN and missing detection in quantile() (#72)
fadeeee fix handling of Missing in cor (#74)
862798b Fix CI badge
27a63ae change real to float in cor of a single collection (#61)
7b56a27 In var, don't compute the mean if provided (#68)
ba90d86 Fix CI (#64)
698530b Add GitHub action for CI (#62)
05f09fe Delete .travis.yml
7a0c0d1 Clarify "IID" (#58)

@DilumAluthge DilumAluthge added domain:statistics The Statistics stdlib module stdlib Julia's standard library labels Jun 9, 2021
@DilumAluthge DilumAluthge requested a review from bkamins June 9, 2021 23:25
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK to make this bump. We have still open https://github.com/JuliaLang/Statistics.jl/pull/70 in a related area to the changes this bump would introduce but it is independent.

However, my question is what is the release policy of Statistics.jl (and in consequence synchronization policy with Julia Base) as I am not aware of standards we use here?

@DilumAluthge
Copy link
Member

DilumAluthge commented Jun 10, 2021

See e.g. this comment by @StefanKarpinski regarding the release cycle of external stdlibs: JuliaLang/BumpStdlibs.jl#31 (comment):

My workflow has generally been to bump stdlibs to Julia master first and only after they've proven to be unproblematic there for a while, tag a release of the stdlib.

@DilumAluthge DilumAluthge merged commit 752ac81 into JuliaLang:master Jun 10, 2021
@bkamins
Copy link
Member

bkamins commented Jun 10, 2021

OK. Thank you. Still I would like to kindly ask @nalimilan to have a look at what state we bump to.

@DilumAluthge
Copy link
Member

@nalimilan Can you take a look at this PR and make sure that the bump is okay?

We can always revert this PR if need be.

@nalimilan
Copy link
Member

Yes I think it's fine. Indeed it makes sense to include recent changes in Julia 1.7.

@DilumAluthge
Copy link
Member

Technically this PR will be in 1.8, since 1.7 was already branched.

That being said, if you want, we can backport this PR to 1.7.

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/Statistics-54f9b0d branch June 11, 2021 06:44
KristofferC pushed a commit that referenced this pull request Jun 17, 2021
@KristofferC KristofferC mentioned this pull request Jun 17, 2021
20 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:statistics The Statistics stdlib module stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants