IncrementalCompact: handle insertion by OldSSAValue before the insert pt #41114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a case that doesn't currently come up in our base transformation passes. However, it's a well defined thing to want to do and I needed it in Diffractor. That said, as more packages are starting to do compiler-y things, we probably want to figure out a way to decouple general compiler utilities from Core.Compiler, but in the meantime, just make this work.
JeffBezanson
added
the
compiler:optimizer
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
… pt (JuliaLang#41114) This is a case that doesn't currently come up in our base transformation passes. However, it's a well defined thing to want to do and I needed it in Diffractor. That said, as more packages are starting to do compiler-y things, we probably want to figure out a way to decouple general compiler utilities from Core.Compiler, but in the meantime, just make this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case that doesn't currently come up in our base transformation
passes. However, it's a well defined thing to want to do and I needed
it in Diffractor. That said, as more packages are starting to do compiler-y
things, we probably want to figure out a way to decouple general compiler
utilities from Core.Compiler, but in the meantime, just make this work.