Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed @boundscheck warning to refer to axes instead of size #41087

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

cljord
Copy link
Contributor

@cljord cljord commented Jun 4, 2021

#39370 mentioned that the @boundscheck warning refers to an array's size instead of its axes.

This pull request changes the reference from size to axes.

Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@simeonschaub simeonschaub added docs This change adds or pertains to documentation merge me PR is reviewed. Merge when all tests are passing labels Jun 4, 2021
@oscardssmith oscardssmith merged commit 87e08d9 into JuliaLang:master Jun 5, 2021
@cljord cljord deleted the cj/boundscheck branch June 5, 2021 06:53
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jun 18, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants