optimizer: organize code and more strongly type OptimizationState.ir
#41081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7c1f65
to
50b76e9
Compare
|
Rebased against the current master. Will merge once I confirm CI get passed, because this PR doesn't change any logic other than code organization. |
|
FWIW, CI is a bit slow right now, so only 13 of the 20 checks ran (though we are unlikely to see platform differences here) |
|
Are you okay/comfortable with this change ? I feel I unnecessarily hurried to merged this. |
|
It sounded fine, so I didn’t look too closely. Possibly somewhat fast, due to the weekend, but not an issue here. |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.