Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML: fix some printing of special characters #41079

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Conversation

KristofferC
Copy link
Member

* fix some printing of special characters
@KristofferC KristofferC added the stdlib Julia's standard library label Jun 4, 2021
@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Jun 6, 2021
@KristofferC KristofferC merged commit 66c3375 into master Jun 6, 2021
@KristofferC KristofferC deleted the kc/toml_fix branch June 6, 2021 08:22
@test roundtrip(s)

d = Dict("str" => string(Char(0xd800)))
@test_throws ErrorException TOML.print(d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have introduced this defect in the test output:

TOML                               (41) |    31.70 |   0.67 |  2.1 |    1230.28 |  1353.48
      From worker 41:   str = "
Suggested change
@test_throws ErrorException TOML.print(d)
@test_throws ErrorException TOML.print(devnull, d)

shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
* TOML: fix some printing of special characters
@KristofferC KristofferC mentioned this pull request Jun 10, 2021
45 tasks
KristofferC added a commit that referenced this pull request Jun 10, 2021
* TOML: fix some printing of special characters

(cherry picked from commit 66c3375)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* TOML: fix some printing of special characters

(cherry picked from commit 66c3375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML printing of strings escaped with \xnn doesn't round trip
3 participants