Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faster +(::BigInt...) for more than 5 arguments #41012

Merged
merged 2 commits into from
May 31, 2021
Merged

faster +(::BigInt...) for more than 5 arguments #41012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fb05b
faster +(::BigInt...) for more than 5 arguments
rfourquet May 30, 2021
5e2ef8a
disallow empty tuple in sum (vtjnash)
rfourquet May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion base/gmp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,9 @@ function gcdx(a::BigInt, b::BigInt)
g, s, t
end

sum(arr::AbstractArray{BigInt}) = foldl(MPZ.add!, arr; init=BigInt(0))
+(x::BigInt, y::BigInt, rest::BigInt...) = sum(tuple(x, y, rest...))
sum(arr::Union{AbstractArray{BigInt}, Tuple{BigInt, Vararg{BigInt}}}) =
foldl(MPZ.add!, arr; init=BigInt(0))
# Note: a similar implementation for `prod` won't be efficient:
# 1) the time complexity of the allocations is negligible compared to the multiplications
# 2) assuming arr contains similarly sized BigInts, the multiplications are much more
Expand Down
5 changes: 5 additions & 0 deletions test/gmp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,15 @@ end
g = parse(BigInt,"-1")

@test +(a, b) == parse(BigInt,"327547")
@test 327547 == sum((a, b)) isa BigInt
@test +(a, b, c) == parse(BigInt,"3426495623485904783805894")
@test 3426495623485904783805894 == sum((a, b, c)) isa BigInt
@test +(a, b, c, d) == parse(BigInt,"3426495623485903384821764")
@test 3426495623485903384821764 == sum((a, b, c, d)) isa BigInt
@test +(a, b, c, d, f) == parse(BigInt,"2413804710837418037418307081437318690130968843290370569228")
@test 2413804710837418037418307081437318690130968843290370569228 == sum((a, b, c, d, f)) isa BigInt
@test +(a, b, c, d, f, g) == parse(BigInt,"2413804710837418037418307081437318690130968843290370569227")
@test 2413804710837418037418307081437318690130968843290370569227 == sum((a, b, c, d, f, g)) isa BigInt

@test *(a, b) == parse(BigInt,"3911455620")
@test *(a, b, c) == parse(BigInt,"13402585563389346256121263521460140")
Expand Down