gcd and lcm fixed for one negative argument #40968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added
kind:bugfix
oscardssmith
approved these changes
May 27, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jun 4, 2021
(cherry picked from commit fb42ea5)
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
75 tasks
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit fb42ea5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have
Same for
lcm.The positive value would make the outcomes above consistent and be in line with e.g. WolframAlpha. (MATLAB does not support one-arg form).