Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with concatenating strings and arrays together #40900

Merged
merged 2 commits into from
May 21, 2021

Conversation

BioTurboNick
Copy link
Contributor

Resolves #40898 by implementing special cat_ndims that returns 0 for non-arrays.

@BioTurboNick BioTurboNick changed the title Patch 5 Fix issue with concatenating strings and arrays together May 21, 2021
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simeonschaub simeonschaub added domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug labels May 21, 2021
@simeonschaub simeonschaub merged commit 139aba6 into JuliaLang:master May 21, 2021
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays [a, r, r, a, y, s] kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvncat always assumes ndims is defined
2 participants