Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the analyzegc and llvmpasses pipelines to buildkite #40826

Merged
merged 5 commits into from
May 19, 2021

Conversation

vchuravy
Copy link
Sponsor Member

For #40774, @staticfloat mentioned that it will be challenging to regenerate the images to include python3
and so I thought I give buildkite a chance for analyzegc and later llvmpasses. This is running on the CI
machines at MIT.

@vchuravy
Copy link
Sponsor Member Author

Example of a successful run https://buildkite.com/julialang/julia/builds/154#a68d0619-79cb-4d89-80d0-080b03722e9d

@DilumAluthge
Copy link
Member

Hmmm. Why isn't Buildkite posting the status on this PR?

@vchuravy
Copy link
Sponsor Member Author

We don't have the webhook configured yet

@vchuravy
Copy link
Sponsor Member Author

Now we get responses back :)

My proposal would be to migrate analyzegc and llvmpasses to the buildkite infrastructure, unblocking #40774, and then take some more time to doe a "proper" buildkite deployment like the one sketched out by @christopher-dG

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a newline at the end of the file. Otherwise LGTM, and the plan you outlined sounds good to me.

@DilumAluthge DilumAluthge added the domain:ci Continuous integration label May 14, 2021
@vchuravy vchuravy marked this pull request as ready for review May 15, 2021 22:20
@DilumAluthge DilumAluthge requested review from staticfloat and removed request for staticfloat May 17, 2021 21:11
@DilumAluthge
Copy link
Member

BTW I turned off Buildkite commit statuses. We should turn them back on right before we merge this PR.

This will give us the ability to time different portions of the build as well
@staticfloat
Copy link
Sponsor Member

Okay I'm good with this for now. I'll integrate this into something more holistic in the future. It looks like the apt-get stuff takes <20 seconds, so I'm fine with just doing it every time for now.

@DilumAluthge
Copy link
Member

I've re-enabled commit statuses.

@DilumAluthge DilumAluthge merged commit d93a1c8 into master May 19, 2021
@DilumAluthge DilumAluthge deleted the vc/buildkite branch May 19, 2021 22:08
shirodkara pushed a commit to shirodkara/julia that referenced this pull request Jun 9, 2021
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
KristofferC pushed a commit that referenced this pull request Jun 10, 2021
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit d93a1c8)
@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Jun 10, 2021
@KristofferC
Copy link
Sponsor Member

Backporting since otherwise we get red CI for buildkite on 1.6 for eternity.

KristofferC pushed a commit that referenced this pull request Jun 10, 2021
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit d93a1c8)
KristofferC pushed a commit that referenced this pull request Jun 11, 2021
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit d93a1c8)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
@DilumAluthge DilumAluthge changed the title Move analyzegc pipeline to buildkite Move the analyzegc and llvmpasses pipeline to buildkite Jul 8, 2021
@DilumAluthge DilumAluthge changed the title Move the analyzegc and llvmpasses pipeline to buildkite Move the analyzegc and llvmpasses pipelines to buildkite Jul 8, 2021
@KristofferC KristofferC mentioned this pull request Jul 12, 2021
75 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* add the analyzegc pipeline

* fixup! add the analyzegc pipeline

* add step for llvmpasses

* Add newline at end of file

* Break buildkite output up into sections

This will give us the ability to time different portions of the build as well

Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Elliot Saba <[email protected]>
(cherry picked from commit d93a1c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants