do not trim trailing zeros of integral part #40755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
vtjnash
reviewed
May 11, 2021
Comment on lines
+552
to
+554
| @show Ryu.writefixed(1.25e+5, 0, false, false, false, UInt8('.'), true) == "125000" | ||
| @show Ryu.writefixed(1.25e+5, 1, false, false, false, UInt8('.'), true) == "125000" | ||
| @show Ryu.writefixed(1.25e+5, 2, false, false, false, UInt8('.'), true) == "125000" |
There was a problem hiding this comment.
bump (@quinnj, as reviewer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting
trimtrailingzeros = trueofRyu.writefixedmay trim trailing zeros of integral part ifprecision = 0, which is surprising because it changes the scale of the value:This PR fixes the problem so that only trailing zeros of fractional part are trimmed. I think this change is not breaking because Ryu is not a part of the official API.