[CLI] ensure error on not finding symbol #40748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sanity check was attempted in #38994, but dlsym is often also okay with finding the trampoline, so we want to also check that it does not use that to resolve the trampoline ad infinitum.
|
How can |
|
dlsym usually searches the dependency list too, which in this case includes libjulia, due to the way we link |
|
The lookup is coming from |
staticfloat
approved these changes
May 8, 2021
|
no, it has nothing to do with where the lookup happened from |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
This sanity check was attempted in JuliaLang#38994, but dlsym is often also okay with finding the trampoline, so we want to also check that it does not use that to resolve the trampoline ad infinitum.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This sanity check was attempted in JuliaLang#38994, but dlsym is often also okay with finding the trampoline, so we want to also check that it does not use that to resolve the trampoline ad infinitum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sanity check was attempted in #38994, but dlsym is often also okay
with finding the trampoline, so we want to also check that it does not
use that to resolve the trampoline ad infinitum.