Five arg mul! for UniformScaling and improvement in exp! #40731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a five argument
mul!
forUniformScaling
as third argument and second isNumber
(and conversely secondNumber
and thirdUniformScaling
).In particular, it provides the possibility to do in-place add of
UniformScaling
-objects. See the discussion in https://discourse.julialang.org/t/uniform-scaling-inplace-addition-with-matrix/The in-place version of
A += s*I
isAs an example / use-case, I have adapted
exp!
(after #40668) where it was needed four times. Compare: