Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in schur for zero dimension matrices #40693

Merged
merged 1 commit into from
May 4, 2021

Conversation

cfauchereau
Copy link
Contributor

Fix #36957
As described in the associated issue, the ldvsl and ldvsr parameters for the lapack gges function must be set to max(1, n) to account for zero dimension matrices.

@dkarrasch dkarrasch added kind:bugfix This change fixes an existing bug domain:linear algebra Linear algebra labels May 3, 2021
@dkarrasch
Copy link
Member

This requires a rebase onto current master, I guess. Some checksums of SuiteSparse appear to be out-of-sync or something?

@dkarrasch dkarrasch added the status:merge me PR is reviewed. Merge when all tests are passing label May 4, 2021
@vtjnash vtjnash merged commit 44d4842 into JuliaLang:master May 4, 2021
@cfauchereau cfauchereau deleted the schur_size_0 branch May 6, 2021 18:47
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
dghosef pushed a commit to dghosef/julia that referenced this pull request May 11, 2021
@simeonschaub simeonschaub removed the status:merge me PR is reviewed. Merge when all tests are passing label May 21, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schur fails for zero dimension matrices
4 participants