Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change some ::AbstractString fields to ::String #40569

Merged
merged 1 commit into from
Apr 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/array.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The objects called do not have matching dimensionality. Optional argument `msg`
descriptive error string.
"""
struct DimensionMismatch <: Exception
msg::AbstractString
msg::String
end
DimensionMismatch() = DimensionMismatch("")

Expand Down
2 changes: 1 addition & 1 deletion base/channels.jl
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ function close_chnl_on_taskdone(t::Task, c::Channel)
end

struct InvalidStateException <: Exception
msg::AbstractString
msg::String
state::Symbol
end

Expand Down
2 changes: 1 addition & 1 deletion base/compiler/validation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const SIGNATURE_NARGS_MISMATCH = "method signature does not match number of meth
const SLOTNAMES_NARGS_MISMATCH = "CodeInfo for method contains fewer slotnames than the number of method arguments"

struct InvalidCodeError <: Exception
kind::AbstractString
kind::String
meta::Any
end
InvalidCodeError(kind::AbstractString) = InvalidCodeError(kind, nothing)
Expand Down
2 changes: 1 addition & 1 deletion base/errorshow.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This method is used to display the exception after a call to [`throw`](@ref).
# Examples
```jldoctest
julia> struct MyException <: Exception
msg::AbstractString
msg::String
end

julia> function Base.showerror(io::IO, err::MyException)
Expand Down
2 changes: 1 addition & 1 deletion base/io.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ struct EOFError <: Exception end
A system call failed with an error code (in the `errno` global variable).
"""
struct SystemError <: Exception
prefix::AbstractString
prefix::String
errnum::Int32
extrainfo
SystemError(p::AbstractString, e::Integer, extrainfo) = new(p, e, extrainfo)
Expand Down
2 changes: 1 addition & 1 deletion base/iostream.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Mostly used to represent files returned by [`open`](@ref).
mutable struct IOStream <: IO
handle::Ptr{Cvoid}
ios::Array{UInt8,1}
name::AbstractString
name::String
mark::Int64
lock::ReentrantLock
_dolock::Bool
Expand Down
2 changes: 1 addition & 1 deletion base/libuv.jl
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ end
## Libuv error handling ##

struct IOError <: Exception
msg::AbstractString
msg::String
code::Int32
IOError(msg::AbstractString, code::Integer) = new(msg, code)
end
Expand Down
2 changes: 1 addition & 1 deletion base/meta.jl
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ The expression passed to the [`parse`](@ref) function could not be interpreted a
expression.
"""
struct ParseError <: Exception
msg::AbstractString
msg::String
end

function _parse_string(text::AbstractString, filename::AbstractString,
Expand Down
2 changes: 1 addition & 1 deletion base/missing.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ where it is not supported. The error message, in the `msg` field
may provide more specific details.
"""
struct MissingException <: Exception
msg::AbstractString
msg::String
end

showerror(io::IO, ex::MissingException) =
Expand Down
2 changes: 1 addition & 1 deletion base/simdloop.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export @simd, simd_outer_range, simd_inner_length, simd_index

# Error thrown from ill-formed uses of @simd
struct SimdError <: Exception
msg::AbstractString
msg::String
end

# Parse iteration space expression
Expand Down
8 changes: 4 additions & 4 deletions base/version_git.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

echo "# This file was autogenerated in base/version_git.sh"
echo "struct GitVersionInfo"
echo " commit::AbstractString"
echo " commit_short::AbstractString"
echo " branch::AbstractString"
echo " commit::String"
echo " commit_short::String"
echo " branch::String"
echo " build_number::Int"
echo " date_string::AbstractString"
echo " date_string::String"
echo " tagged_commit::Bool"
echo " fork_master_distance::Int"
echo " fork_master_timestamp::Float64"
Expand Down
2 changes: 1 addition & 1 deletion stdlib/Mmap/src/Mmap.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const PAGESIZE = Int(Sys.isunix() ? ccall(:jl_getpagesize, Clong, ()) : ccall(:j

# for mmaps not backed by files
mutable struct Anonymous <: IO
name::AbstractString
name::String
readonly::Bool
create::Bool
end
Expand Down
2 changes: 1 addition & 1 deletion stdlib/SuiteSparse/src/cholmod_h.jl
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const VTypes = Union{ComplexF64, Float64}
const VRealTypes = Union{Float64}

struct CHOLMODException <: Exception
msg::AbstractString
msg::String
end

macro isok(A)
Expand Down
2 changes: 1 addition & 1 deletion stdlib/SuiteSparse/src/umfpack.jl
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import ..increment, ..increment!, ..decrement, ..decrement!

include("umfpack_h.jl")
struct MatrixIllConditionedException <: Exception
msg::AbstractString
msg::String
end

function umferror(status::Integer)
Expand Down
2 changes: 1 addition & 1 deletion stdlib/Test/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ import Test: record, finish
using Test: get_testset_depth, get_testset
using Test: AbstractTestSet, Result, Pass, Fail, Error
struct CustomTestSet <: Test.AbstractTestSet
description::AbstractString
description::String
foo::Int
results::Vector
# constructor takes a description string and options keyword arguments
Expand Down