Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Unicode named subpatterns and property mixes #40328

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Add test for Unicode named subpatterns and property mixes #40328

merged 1 commit into from
Apr 3, 2021

Conversation

BenjaminGalliot
Copy link
Contributor

@BenjaminGalliot BenjaminGalliot commented Apr 3, 2021

This new test is related to issues #35322/#35459 (Unicode named subpatterns) and #40231 (property mixes of Unicode scripts and classes), and PR #39310.

@BenjaminGalliot BenjaminGalliot marked this pull request as ready for review April 3, 2021 18:07
@KristofferC KristofferC merged commit 8b6a778 into JuliaLang:master Apr 3, 2021
@BenjaminGalliot BenjaminGalliot deleted the regex-test branch April 3, 2021 18:59
@BenjaminGalliot
Copy link
Contributor Author

Should this PR be added to the 1.6.1 backport (#40209)? I think it could be good to link them.

@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Apr 6, 2021
KristofferC pushed a commit that referenced this pull request Apr 6, 2021
KristofferC pushed a commit that referenced this pull request Apr 6, 2021
@KristofferC KristofferC mentioned this pull request Apr 6, 2021
33 tasks
KristofferC pushed a commit that referenced this pull request Apr 6, 2021
@KristofferC
Copy link
Sponsor Member

This PR doesn't work as is on 1.6 because it uses API that doesn't exist there. If you make a PR against that branch with the older API, it can be backported.

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Apr 6, 2021
@BenjaminGalliot
Copy link
Contributor Author

Yes, sorry, I forgot this last line in the test would be invalid for 1.6! I just made a small PR specifically for the backport branch.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Apr 6, 2021

I think in general, we don't need to backport test-only PRs, though no harm in merging yours!

@BenjaminGalliot
Copy link
Contributor Author

BenjaminGalliot commented Apr 6, 2021

That's what I thought too, but as I had seen in this current backport list a PR with a one-character spelling correction, I thought it might be worth it, especially as if I had done this test earlier, we would have noticed this breaking change which generated a not so obvious bug in one of my projects! :-)

DilumAluthge pushed a commit that referenced this pull request Apr 6, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants