Fix issue where approved credentials were not sent to git credential helpers #40161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the bug in the `GitCredential` constructor we were never writing credential data to the credential helper effectively making our use of git credential helpers read-only.
omus
added
backport 1.6
|
I believe the reason I hadn't noticed this earlier is I use the |
|
I'll add all the backport labels as it affects all of these versions and the fix is small and should apply cleanly |
|
Single buildbot failure is from LibGit2_jll. All of the LibGit2 tests passed on that buildbot |
|
Will merge by end of day if there are no other comments |
|
Thanks for finding and fixing that! |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…helpers (JuliaLang#40161) Due to the bug in the `GitCredential` constructor we were never writing credential data to the credential helper effectively making our use of git credential helpers read-only.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…helpers (JuliaLang#40161) Due to the bug in the `GitCredential` constructor we were never writing credential data to the credential helper effectively making our use of git credential helpers read-only.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…helpers (JuliaLang#40161) Due to the bug in the `GitCredential` constructor we were never writing credential data to the credential helper effectively making our use of git credential helpers read-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Julia user was setup to use git credential helpers then Julia was supposed to interact with the credential helpers such that if a user was prompted for credentials those credentials would be sent to the helper and stored appropriately. Due to this bug a user would be repeated asked for credentials which is annoying. Unfortunately, only if a user had used
gitor another tool that properly interacted with the helpers would the prompts be avoided. Essentially Julia was interacting with the helpers in a read-only mode.This is a long standing issue that was introduced in: 8abc616fb0#diff-c023d2e7a114f660901703fc5bec91bcff1215f598f6126561a050defeced5d1R31.