mention use of underscore for private fields in manual #40131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would make them two different bullet points. |
simeonschaub
commented
Mar 21, 2021
DilumAluthge
approved these changes
Mar 21, 2021
|
Eh, I must say I personally don't really like this. This gives the notion that functions without underscore are somehow public which isn't true at all. Just looking at Base, there are almost no functions with underscore but most functions are private. |
|
I see what you mean. Maybe something more like:
|
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Update variables.md * Update style-guide.md * Apply suggestions from code review
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Update variables.md * Update style-guide.md * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether this should be mentioned both in the Variables section and in the style guide. I also noticed the
!convention was not mentioned in the style guide, so I added that as well, but I can remove that part if this is not the right place.Ref #40127