Add HISTORY.md entry for change noted in #39589 #39784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sostock
added a commit
to sostock/julia
that referenced
this pull request
Feb 22, 2021
This was referenced Feb 22, 2021
|
I think it would be best to frame this as a bugfix from the beginning. Phrases like "now always describe" and "is considered a bugfix" risk making it sound like a bit of a dicey change to be making in the middle of a stable release cycle. But bugfixes can always break someone's code (I won't bother to link the obligatory xkcd on the topic). But it's just a bugfix, pure and simple, no excuses needed. This just makes it consistent with how |
mbauman
reviewed
Feb 23, 2021
Following mbauman’s suggestion: JuliaLang#39784 (comment) Co-authored-by: Matt Bauman <[email protected]>
sostock
added a commit
to sostock/julia
that referenced
this pull request
Feb 26, 2021
Following mbauman’s suggestion: JuliaLang#39784 (comment) Co-authored-by: Matt Bauman <[email protected]>
mbauman
approved these changes
Feb 26, 2021
14 tasks
|
This has been backported to 1.6-rc3, so this PR can be merged now. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…9784) * Add HISTORY.md entry for change noted in JuliaLang#39589 * Rephrase Following mbauman’s suggestion: JuliaLang#39784 (comment) Co-authored-by: Matt Bauman <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…9784) * Add HISTORY.md entry for change noted in JuliaLang#39589 * Rephrase Following mbauman’s suggestion: JuliaLang#39784 (comment) Co-authored-by: Matt Bauman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #39589 (comment), it could be good to mention this change in NEWS/HISTORY. This adds a HISTORY.md item. I will also make a PR backporting this to the 1.6 NEWS.md file.
Edit: backport PR: #39785