make it possible to serialize SnoopCompile results #39695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `nothing` instead of NULL as a sentinel in specializations - remove some Serializer restrictions around saving Methods
be7ac9c
to
392df13
Compare
Sacha0
approved these changes
Feb 17, 2021
|
Backport candidate, or bridge too far? :) |
|
The serializer part I think is just a bugfix, since the |
vtjnash
reviewed
Feb 25, 2021
Co-authored-by: Jameson Nash <[email protected]>
|
This seems generally somewhat risky to copy in this way, but generally no worse than deepcopy of other things |
simeonschaub
added a commit
to simeonschaub/Cthulhu.jl
that referenced
this pull request
Mar 31, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
- use `nothing` instead of NULL as a sentinel in specializations - remove some Serializer restrictions around saving Methods
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
- use `nothing` instead of NULL as a sentinel in specializations - remove some Serializer restrictions around saving Methods
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
- use `nothing` instead of NULL as a sentinel in specializations - remove some Serializer restrictions around saving Methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #39655. I don't think it will realistically be possible for JLD to support these data structures, but
Serializationmight as well support it at least.nothinginstead of NULL as a sentinel in specializations. This field is technically visible and we don't support user-visible SimpleVectors with NULLsmethod.generatorwas broken. We disallowed serializing non-toplevel MethodInstance objects, but I don't see a good reason for that --- we might as well just save the data even if you can't do much with it.