Add Base.isdone(itr::EachLine)
#39562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcaine
commented
Feb 7, 2021
cmcaine
commented
Feb 7, 2021
simeonschaub
added
domain:io
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
|
Now has tests. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
With this method, `isempty` won't consume values from the iterator (See JuliaLang#27412).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this method,
isemptywon't consume values from the iterator (See #27412).This is completely untested. I'm trusting the CI to pick up any problems.
If this works and is accepted then I can do another PR for some of the other stateful iterators in Base.