faster, more accurate log2, log10 #39556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses our existing very good
log
implementation forlog2
andlog10
. This both reduces error, and increases speed forFloat32
andFloat64
. There is no impact onlog
(other than a pretty minor performance regression forFloat64
). I think I can solve the regression fairly easily, so I'm pushing it now so it can be reviewed (and I can see if CI passes)