Clean direct ccalls to jl_specializations_get_linfo #39490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Feb 2, 2021
| @@ -148,12 +148,8 @@ function _dump_function(@nospecialize(f), @nospecialize(t), native::Bool, wrappe | |||
| end | |||
| # get the MethodInstance for the method match | |||
| world = typemax(UInt) | |||
| meth = which(f, t) | |||
There was a problem hiding this comment.
This isn't quite the same query, as this was subtyping (aka invoke), while the other is type-intersection:
julia> which(+, (Integer, Integer))
+(a::Integer, b::Integer) in Base at int.jl:921
julia> methods(+, (Integer, Integer))
# 8 methods for generic function "+":
[1] +(x::T, y::T) where T<:Union{Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8} in Base at int.jl:87
[2] +(c::Union{UInt16, UInt32, UInt64, UInt8}, x::BigInt) in Base.GMP at gmp.jl:528
[3] +(c::Union{Int16, Int32, Int64, Int8}, x::BigInt) in Base.GMP at gmp.jl:534
[4] +(x::BigInt, y::BigInt) in Base.GMP at gmp.jl:479
[5] +(x::BigInt, c::Union{UInt16, UInt32, UInt64, UInt8}) in Base.GMP at gmp.jl:527
[6] +(x::BigInt, c::Union{Int16, Int32, Int64, Int8}) in Base.GMP at gmp.jl:533
[7] +(x::Bool, y::Bool) in Base at bool.jl:92
[8] +(a::Integer, b::Integer) in Base at int.jl:921
Many of these were using an incorrect (outdated) signature for this ccall. We now wrap this method in Core.Compiler.specialize_method, so clean up all the places that were using it directly.
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Many of these were using an incorrect (outdated) signature for this ccall. We now wrap this method in Core.Compiler.specialize_method, so clean up all the places that were using it directly.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Many of these were using an incorrect (outdated) signature for this ccall. We now wrap this method in Core.Compiler.specialize_method, so clean up all the places that were using it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of these were using an incorrect (outdated) signature for this ccall.
We now wrap this method in Core.Compiler.specialize_method, so
clean up all the places that were using it directly.