Run jl_resolve_globals_in_ir on the result of generated functions #39483
Conversation
We didn't use to run this when the generated function returned a CodeInfo (though we did run it for AST). However, now that this also does the conversion of :opaque_closure_method to actual Method objects, I think the best thing to do would be to run it here to avoid the generated function having to construct its own Method object from scratch.
| $(Expr(:meta, :generated_only)) | ||
| $(Expr(:meta, | ||
| :generated, | ||
| Expr(:new, |
There was a problem hiding this comment.
Could this be written using @generated to depend less on implementation details?
There was a problem hiding this comment.
I don't think @generated are allowed to return CodeInfo anymore.
There was a problem hiding this comment.
When did that happen? So can we remove the rest of the code supporting it?
There was a problem hiding this comment.
Generated functions still support it, you just can't get there with the @generated syntax. If you try it, the macro will wrap it in an AST for you. No idea if that was intentional, but I assume it happened when the generated function internals were changed.
|
As per discussion yesterday, we need some way of identifying these methods once we allow them in inference. However, since inference just ignores these currently, I think this PR is good to merge as is. @JeffBezanson @vtjnash anything I missed? |
…liaLang#39483) We didn't use to run this when the generated function returned a CodeInfo (though we did run it for AST). However, now that this also does the conversion of :opaque_closure_method to actual Method objects, I think the best thing to do would be to run it here to avoid the generated function having to construct its own Method object from scratch.
…liaLang#39483) We didn't use to run this when the generated function returned a CodeInfo (though we did run it for AST). However, now that this also does the conversion of :opaque_closure_method to actual Method objects, I think the best thing to do would be to run it here to avoid the generated function having to construct its own Method object from scratch.
We didn't use to run this when the generated function returned
a CodeInfo (though we did run it for AST). However, now that
this also does the conversion of :opaque_closure_method to
actual Method objects, I think the best thing to do would
be to run it here to avoid the generated function having
to construct its own Method object from scratch.