Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: mostly fix uses of undefined PhiNodes #39236

Merged
merged 1 commit into from
Jan 14, 2021
Merged

codegen: mostly fix uses of undefined PhiNodes #39236

merged 1 commit into from
Jan 14, 2021

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jan 13, 2021

Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes #39232

@vtjnash vtjnash added the backport 1.6 Change should be backported to release-1.6 label Jan 13, 2021
@vtjnash vtjnash requested a review from Keno January 13, 2021 20:50
@vtjnash
codegen: mostly fix uses of undefined PhiNodes
46f2bdd 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes #39232
Keno
Keno approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@vtjnash vtjnash merged commit 051f47b into master Jan 14, 2021
@vtjnash vtjnash deleted the jn/39232 branch January 14, 2021 23:50
@KristofferC KristofferC mentioned this pull request Jan 19, 2021
Merged
60 tasks
KristofferC pushed a commit that referenced this pull request Jan 19, 2021
@vtjnash @KristofferC
codegen: mostly fix uses of undefined PhiNodes (#39236)
51653b4 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes #39232

(cherry picked from commit 051f47b)
@maleadt maleadt mentioned this pull request Jan 19, 2021
Closed
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@vtjnash @KristofferC
codegen: mostly fix uses of undefined PhiNodes (#39236)
aca8fa2 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes #39232

(cherry picked from commit 051f47b)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
codegen: mostly fix uses of undefined PhiNodes (JuliaLang#39236)
34fe2c3 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes JuliaLang#39232
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@vtjnash @antoine-levitt
codegen: mostly fix uses of undefined PhiNodes (JuliaLang#39236)
d2d425e 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes JuliaLang#39232
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
codegen: mostly fix uses of undefined PhiNodes (#39236)
7e88368 
Unlike the rest of codegen, we permit PhiNodes to legally return
undefined values, so we need to carefully skip those.

Fixes #39232

(cherry picked from commit 051f47b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unreachable reached in enumerate of a tuple in Julia v1.6.0-beta1
3 participants
@vtjnash @Keno @KristofferC