Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy libgomp as part of CSL build #39212

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Copy libgomp as part of CSL build #39212

merged 1 commit into from
Jan 13, 2021

Conversation

omus
Copy link
Member

@omus omus commented Jan 12, 2021

When building Julia dependencies without BinaryBuilder I would see the following error when running the CompilerSupportLibraries_jll tests:

julia> Base.runtests("CompilerSupportLibraries_jll")
...
CompilerSupportLibraries_jll       (9) |         failed at 2021-01-12T11:46:36.499
Error During Test at /Users/omus/Development/Julia/x86/latest-src/test/testdefs.jl:21
  Got exception outside of a @test
  LoadError: InitError: could not load library "@rpath/libgomp.1.dylib"
  dlopen(@rpath/libgomp.1.dylib, 1): image not found

@omus omus added domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jan 12, 2021
@omus
Copy link
Member Author

omus commented Jan 12, 2021

CI didn't seem to trigger itself

@DilumAluthge
Copy link
Member

CI didn't seem to trigger itself

Probably the queue is backed up. Buildbot doesn't post a "pending" status until the job is actually started on a runner.

@omus omus merged commit 7e85405 into master Jan 13, 2021
@omus omus deleted the cv/csl-build-fix branch January 13, 2021 15:46
@Sacha0 Sacha0 added the backport 1.6 Change should be backported to release-1.6 label Jan 25, 2021
@Sacha0
Copy link
Member

Sacha0 commented Jan 25, 2021

(We ran into this issue on release-1.6 as well, and were about to submit an identical patch, so marking for backport :).)

KristofferC pushed a commit that referenced this pull request Jan 26, 2021
@omus @KristofferC
Copy libgomp as part of CSL build (#39212)
ba575ca 
(cherry picked from commit 7e85405)
@KristofferC KristofferC mentioned this pull request Jan 26, 2021
Merged
60 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@omus @KristofferC
Copy libgomp as part of CSL build (#39212)
1d5bb59 
(cherry picked from commit 7e85405)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@omus @ElOceanografo
Copy libgomp as part of CSL build (JuliaLang#39212)
96c55cb
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@omus @antoine-levitt
Copy libgomp as part of CSL build (JuliaLang#39212)
b9fe892
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@omus @staticfloat
Copy libgomp as part of CSL build (#39212)
ff337f2 
(cherry picked from commit 7e85405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omus @DilumAluthge @Sacha0 @staticfloat @KristofferC