Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libldl to SuiteSparse libs #39211

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Add libldl to SuiteSparse libs #39211

merged 1 commit into from
Jan 13, 2021

Conversation

omus
Copy link
Member

@omus omus commented Jan 12, 2021

When building Julia dependencies without BinaryBuilder I would see the following error when running the SuiteSparse_jll tests:

julia> Base.runtests("SuiteSparse_jll")
Test        (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
SuiteSparse_jll  (1) |        started at 2021-01-12T13:13:58.157
SuiteSparse_jll  (1) |         failed at 2021-01-12T13:13:59.625
Error During Test at /Users/omus/Development/Julia/x86/latest-src/usr/share/julia/test/testdefs.jl:21
  Got exception outside of a @test
  LoadError: InitError: could not load library "@rpath/libldl.2.dylib"
  dlopen(@rpath/libldl.2.dylib, 1): image not found

@omus omus added domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Jan 12, 2021
@omus omus merged commit 491d925 into master Jan 13, 2021
@omus omus deleted the cv/suitesparse-build-fix branch January 13, 2021 15:45
@Sacha0 Sacha0 added the backport 1.6 Change should be backported to release-1.6 label Jan 25, 2021
@Sacha0
Copy link
Member

Sacha0 commented Jan 25, 2021

(We ran into this issue on release-1.6 as well, and were about to submit an identical patch, so marking for backport :).)

KristofferC pushed a commit that referenced this pull request Jan 26, 2021
@omus @KristofferC
Add libldl to SuiteSparse libs (#39211)
f5be2e5 
(cherry picked from commit 491d925)
@KristofferC KristofferC mentioned this pull request Jan 26, 2021
Merged
60 tasks
@omus
Copy link
Member Author

omus commented Jan 26, 2021

(We ran into this issue on release-1.6 as well, and were about to submit an identical patch, so marking for backport :).)

Glad these fixes are helpful :)

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@omus @KristofferC
Add libldl to SuiteSparse libs (#39211)
018cb1a 
(cherry picked from commit 491d925)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@omus @ElOceanografo
Add libldl to SuiteSparse libs (JuliaLang#39211)
1a36311
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@omus @antoine-levitt
Add libldl to SuiteSparse libs (JuliaLang#39211)
4113ab5
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@omus @staticfloat
Add libldl to SuiteSparse libs (#39211)
f6b418c 
(cherry picked from commit 491d925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omus @Sacha0 @staticfloat @KristofferC