Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #39117, overly-specific type from default_eltype #39130

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix #39117, overly-specific type from default_eltype #39130

merged 1 commit into from
Jan 7, 2021

Conversation

JeffBezanson
Copy link
Sponsor Member

fix #39117

@JeffBezanson JeffBezanson added kind:bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 labels Jan 6, 2021
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 6, 2021

Don’t we already have this for the Stateful Iterator? This seems insufficient if inference can identify the last iteration (the same problem as before, but with last instead of first)

@JeffBezanson
Copy link
Sponsor Member Author

Ah, I thought we might have that already implemented somewhere. It's not quite right though --- it aggressively widens to Any, and only seems to consider the first 2 calls to iterate.

@JeffBezanson
Copy link
Sponsor Member Author

How about this version?

@JeffBezanson JeffBezanson merged commit 66c9f6a into master Jan 7, 2021
@JeffBezanson JeffBezanson deleted the jb/fix39117 branch January 7, 2021 16:58
KristofferC pushed a commit that referenced this pull request Jan 8, 2021
@JeffBezanson @KristofferC
fix #39117, overly-specific type from default_eltype (#39130)
38f3b1e 
(cherry picked from commit 66c9f6a)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 8, 2021
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
@JeffBezanson @staticfloat
fix #39117, overly-specific type from default_eltype (#39130)
bb5ebfc 
(cherry picked from commit 66c9f6a)
@simeonschaub simeonschaub mentioned this pull request Jan 30, 2021
Merged
12 tasks
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@JeffBezanson @ElOceanografo
fix JuliaLang#39117, overly-specific type from default_eltype (Juli…
af23341 
…aLang#39130)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@JeffBezanson @staticfloat
fix #39117, overly-specific type from default_eltype (#39130)
cbb5d2b 
(cherry picked from commit 66c9f6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dict comprehension broken for mixed type dict
3 participants
@JeffBezanson @vtjnash @KristofferC