Test for Windows delete permissions in system folders #39078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunate that packaging is broken on precisely the platforms that need to be tested here. |
|
This is nice on our CI, but I believe this will fail if a user runs the testsuite on a Windows machine and they don't have Admin privileges. I'm not sure if we want that or not, just throwing it out there. |
staticfloat
approved these changes
Jan 5, 2021
The user doesn't need to have Admin privileges for these tests to pass, even for local accounts. |
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2021
(cherry picked from commit ed89ae7)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
(cherry picked from commit ed89ae7)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit ed89ae7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression tests for #38433 #38411