Various fixes to trampolines for embedding on Windows #39052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows libjulia's initialization routines to properly output to `stdout` in embedding scenarios.
By naming the section `text` instead of `.text` these sections were mapped into memory without the executable bit set, causing segfaults when attempting to use any trampolines on Windows.
There are multiple ways of fixing this, but let's just not let trampolines get re-set after they've already been set.
|
I guess backport? |
|
yes |
|
I can confirm that this fixes the tests for DynamicallyLoadedEmbedding when running the nightly build locally on Windows. It still failed the GitHub actions tests on Windows nightly, https://github.com/GunnarFarneback/DynamicallyLoadedEmbedding.jl/runs/1629567916, but I don't know if that might be lagging behind. The log does include the output of |
|
Yeah, try it again in a couple of hours and see if it still fails. |
|
Waiting was enough. Now it's passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GunnarFarneback this fixed your dynamic embedding test suite on Windows for me; I'd appreciate if you could corroborate.
Many thanks to @Keno and @vchuravy for teaching me how to track down the reason behind the segfault; turns out it was an improperly-named section that wasn't getting the right execute bits set for its pages. The tool to figure this out is vmmap, made by sysinternals, as all good windows tools usually are.