document how to use at_test_logs to check for no warnings #39025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1732ca3
to
bb01240
Compare
|
I don't see how the changes of this PR could cause the test failure. |
|
An appropriate label would be |
|
Bump. Is there any interest in this? |
|
It looks like something similar was added in #39670, but I thought the extra details here were useful. I've taken the liberty of combining them and refining the text some more for tone. |
vtjnash
reviewed
Apr 16, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…39025) closes JuliaLang#37307 Co-authored-by: Jameson Nash <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…39025) closes JuliaLang#37307 Co-authored-by: Jameson Nash <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…39025) closes JuliaLang#37307 Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents how to use
@test_logsto check for no warnings. Additionally, I addedLogging.to themin_levels to make it more clear (sincemin_level=Warndoes not work on Julia v1.5, even afterusing Logging).