Fix missing escape in Makefile comments #39022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
added
the
domain:building
Merged
Keno
added a commit
that referenced
this pull request
Apr 12, 2021
* Fix wine bootstrap Fixes #39124 Closes #39022 * fix cross-build, and other build issues * this should probably be part of spawn, if it is needed * Revert "this should probably be part of spawn, if it is needed" This reverts commit eb88a9c. Seems to be needed * fixup! fix cross-build, and other build issues Co-authored-by: Jameson Nash <[email protected]>
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Fix wine bootstrap Fixes JuliaLang#39124 Closes JuliaLang#39022 * fix cross-build, and other build issues * this should probably be part of spawn, if it is needed * Revert "this should probably be part of spawn, if it is needed" This reverts commit eb88a9c. Seems to be needed * fixup! fix cross-build, and other build issues Co-authored-by: Jameson Nash <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Fix wine bootstrap Fixes JuliaLang#39124 Closes JuliaLang#39022 * fix cross-build, and other build issues * this should probably be part of spawn, if it is needed * Revert "this should probably be part of spawn, if it is needed" This reverts commit eb88a9c. Seems to be needed * fixup! fix cross-build, and other build issues Co-authored-by: Jameson Nash <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Fix wine bootstrap Fixes JuliaLang#39124 Closes JuliaLang#39022 * fix cross-build, and other build issues * this should probably be part of spawn, if it is needed * Revert "this should probably be part of spawn, if it is needed" This reverts commit eb88a9c. Seems to be needed * fixup! fix cross-build, and other build issues Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a shell escape error when attempting to cross-compile. Fix is from @vtjnash, opening this so he doesn't forget again 😅
...Hmm this doesn't want to work on Cygwin