Fix insert_node_here! if called at the end of the IR #39021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was throwing an error when called after the compaction had processes the last instruction in the IR (with reverse affinity). This currently can't, because we never use this method after compacting a terminal instruction (inlining uses it to split BBs), but can after the new code in #37849, so fix the bug now. Forward port from #37849.
vtjnash
approved these changes
Dec 29, 2020
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This method was throwing an error when called after the compaction had processes the last instruction in the IR (with reverse affinity). This currently can't, because we never use this method after compacting a terminal instruction (inlining uses it to split BBs), but can after the new code in JuliaLang#37849, so fix the bug now. Forward port from JuliaLang#37849.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was throwing an error when called after the compaction
had processes the last instruction in the IR (with reverse affinity).
This currently can't happen, because we never use this method after compacting
a terminal instruction (inlining uses it to split BBs), but can after
the new code in #37849, so fix the bug now. Forward port from #37849.