Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs about let blocks #39003

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Improve docs about let blocks #39003

merged 2 commits into from
Dec 28, 2020

Conversation

nalimilan
Copy link
Member

This section was probably written before the distinction between hard and soft scopes was added.

I'll run CI once we agree on the phrasing (is there a way to run CI only for docs?).

@nalimilan
Improve docs about let blocks
5be52d6 
This section was probably written before the distinction between
hard and soft scopes was added.

[ci skip]
@nalimilan nalimilan added the domain:docs This change adds or pertains to documentation label Dec 26, 2020
Sacha0
Sacha0 approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up to date on the nuances, but naively this looks great! Thanks Milan! :)

simeonschaub
simeonschaub reviewed Dec 26, 2020
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have some small suggestions in terms of word choice, but otherwise LGTM.

base/docs/basedocs.jl Outdated Show resolved Hide resolved
doc/src/manual/variables-and-scoping.md Outdated Show resolved Hide resolved
@simeonschaub
Copy link
Member

simeonschaub commented Dec 26, 2020 •
edited
Loading

(is there a way to run CI only for docs?)

Not AFAIK, but because CI is just so fast now, I feel less bad about it :)

@nalimilan nalimilan merged commit c3d7338 into master Dec 28, 2020
@nalimilan nalimilan deleted the nl/let branch December 28, 2020 14:26
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@nalimilan @ElOceanografo
Improve docs about let blocks (JuliaLang#39003)
f06edca 
This section was probably written before the distinction between
hard and soft scopes was added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

@Sacha0 Sacha0 Sacha0 approved these changes

@StefanKarpinski StefanKarpinski Awaiting requested review from StefanKarpinski

Assignees
No one assigned
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nalimilan @simeonschaub @Sacha0