Remove restriction on documenting empty baremodules #38998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Dec 25, 2020
test/docs.jl
Outdated
| @@ -1236,3 +1236,7 @@ Test.collect_test_logs() do # suppress printing of any | |||
| eval(quote "Second docstring" Module29432 end) # requires toplevel | |||
| end | |||
| @test docstrings_equal(@doc(Module29432), doc"Second docstring") | |||
|
|
|||
| # Issue #13109 | |||
| eval(Expr(:macrocall, GlobalRef(Core, "@doc"), nothing, Expr(:module, false, MBareModuleEmpty, Expr(:block)))) | |||
There was a problem hiding this comment.
Suggested change
| eval(Expr(:macrocall, GlobalRef(Core, "@doc"), nothing, Expr(:module, false, MBareModuleEmpty, Expr(:block)))) | |
| eval(Expr(:macrocall, GlobalRef(Core, "@doc"), nothing, Expr(:module, false, :MBareModuleEmpty, Expr(:block)))) |
vtjnash
approved these changes
Dec 25, 2020
Replaces and closes #13109. The underlying bug here appears to have been fixed and the restriction here was never triggered since lowering now always inserts LineNumberNodes, but we might as well remove the restriction since the bug is fixed.
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Replaces and closes JuliaLang#13109. The underlying bug here appears to have been fixed and the restriction here was never triggered since lowering now always inserts LineNumberNodes, but we might as well remove the restriction since the bug is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces and closes #13109. The underlying bug here appears to have
been fixed and the restriction here was never triggered since lowering
now always inserts LineNumberNodes, but we might as well remove the
restriction since the bug is fixed.