Use dot and views in QR code #38973
Use dot and views in QR code #38973
Conversation
| end | ||
| end | ||
| @inbounds for j = 1:n | ||
| Aj, xj = view(A, 2:m, j), view(x, 2:m) |
There was a problem hiding this comment.
I would split this into two lines (but that's personal preference)
haampie
force-pushed
the
use-dot-and-views-in-qr
branch
from
8822b08
to
512ccf2
Compare
|
What's also weird is that many function signatures for QR require StridedMatrices (e.g. reflectorApply!, qr!). I don't really see that being exploited anywhere. Should I drop it? For instance StructArray types are not QR'able. |
|
Great, could have anticipated this would lead to even more |
haampie
force-pushed
the
use-dot-and-views-in-qr
branch
from
d6ac360
to
4601220
Compare
|
Should this be merged? |
|
The pr like good to me. That said, we might want to run nanosoldier to check for regressions first. |
|
@nanosoldier I don't know how to run more specific benchmarks, like "linalg" & "array" & "sparse". Any hint would be appreciated. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
|
Hm, after all I'm not sure we have benchmark tests for each and every factorization etc. To get a quick impression, targeted benchmarks may be more illuminating. |
|
Is there a not too difficult way to test the new |
The QR-code is quite ancient, and was written without using other linalg routines because views were expensive then. This lets LinearAlgebra to use dot and norm and such, which are likely optimized for special number types.
The QR-code is quite ancient, and was written without using other linalg routines because views were expensive then. This lets LinearAlgebra to use dot and norm and such, which are likely optimized for special number types.
The QR-code is quite ancient, and was written without using other linalg routines because views were expensive then. This lets LinearAlgebra to use dot and norm and such, which are likely optimized for special number types.
The QR-code is quite ancient, and was written without using other linalg routines because views were expensive then. I'd like LinearAlgebra to use
dotandnormand such, because they are likely optimized for special number types.