Execute backtrace once before testing formatting
#38886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms (PowerPC) the call to the `jlplt` is not a tail-call and so it will be part of the backtrace. This means we are off-by-one and won't skip the Julia function `backtrace` messing up tests that check precise formatting.
vchuravy
added
backport 1.6
Is tailcall still broken on PPC? If so maybe ask the LLVM PPC team to look into it? |
|
Yeah turning on |
|
Perhaps the issue should be left open, this doesn't really fix the core of the problem I guess. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 17, 2020
On some platforms (PowerPC) the call to the `jlplt` is not a tail-call and so it will be part of the backtrace. This means we are off-by-one and won't skip the Julia function `backtrace` messing up tests that check precise formatting. (cherry picked from commit fc577d0)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
On some platforms (PowerPC) the call to the `jlplt` is not a tail-call and so it will be part of the backtrace. This means we are off-by-one and won't skip the Julia function `backtrace` messing up tests that check precise formatting. (cherry picked from commit fc577d0)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
On some platforms (PowerPC) the call to the `jlplt` is not a tail-call and so it will be part of the backtrace. This means we are off-by-one and won't skip the Julia function `backtrace` messing up tests that check precise formatting.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
On some platforms (PowerPC) the call to the `jlplt` is not a tail-call and so it will be part of the backtrace. This means we are off-by-one and won't skip the Julia function `backtrace` messing up tests that check precise formatting. (cherry picked from commit fc577d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38858
On some platforms (PowerPC) the call to the
jlpltis not a tail-calland so it will be part of the backtrace. This means we are off-by-one
and won't skip the Julia function
backtracemessing up tests thatcheck precise formatting.