improve inferrabilities within TOML module #38831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Dec 11, 2020
KristofferC
reviewed
Dec 11, 2020
KristofferC
reviewed
Dec 11, 2020
| @@ -976,9 +979,10 @@ function parse_datetime(l) | |||
| end | |||
|
|
|||
| function try_return_datetime(p, year, month, day, h, m, s, ms) | |||
| if p.Dates !== nothing | |||
| Dates = p.Dates | |||
KristofferC
approved these changes
Dec 11, 2020
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2020
* improve inferrability within TOML module * simplify with `@try` macro * apply suggestion, use `Int64` (cherry picked from commit b3eaa34)
staticfloat
pushed a commit
that referenced
this pull request
Jan 15, 2021
* improve inferrability within TOML module * simplify with `@try` macro * apply suggestion, use `Int64` (cherry picked from commit b3eaa34)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* improve inferrability within TOML module * simplify with `@try` macro * apply suggestion, use `Int64`
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* improve inferrability within TOML module * simplify with `@try` macro * apply suggestion, use `Int64` (cherry picked from commit b3eaa34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.