generate llvm global variables for most literal_pointer_val calls #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was kind of annoying: ihnorton@6c3dcda (in case anything else might be useful, I rebased that pr to latest master: https://github.com/ihnorton/julia/tree/reloadso2 ) |
ghost
assigned 
|
bump Still relevant for 0.2 release? |
|
Not for 0.2, this might be 0.3, since it allows statically compiling code |
|
Why not keep this open? I was hoping to get to this post-0.2. Obviously we are not putting any more risky compiler changes in 0.2. |
|
I closed because I was concerned someone might try to merge this, or work from it. I have more work on one of my local branches which deviates from this. Merging this was only if it was necessary for making 0.2 compatible with 0.3. It doesn't appear to be necessary, so it is probably better to do the majority of the changes all at once. |
KristofferC
pushed a commit
that referenced
this pull request
May 2, 2024
Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 8f772ffa7 New commit: a0851bcfd Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@8f772ff...a0851bc ``` $ git log --oneline 8f772ffa7..a0851bcfd a0851bcfd Relax overly-specific manifest tests (#3884) 299b77093 guard against isdir EACESS in completions (#3877) b9c39a7be Merge pull request #3883 from JuliaLang/kc/resolve_tree_hash 8ab562f72 instantiate the test environment if it is in the current workspace when testing 1d961c1c9 get the correct manifest file for a workspace e468facb5 allow `resolve` to download packages that have been deleted from disk but has a manifest entry 20ceec9b8 do not precompile full env on `using` callback from REPL (#3876) 195e17e3f Replace UnstableIO with IOContext{IO} (#3735) 00aa38cb3 add missing `**5.**` (#3870) ac5672dad Revert "Move "Creating Packages" to Julia docs" (#3818) ``` Co-authored-by: Dilum Aluthge <[email protected]>
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
…#54316) Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: 8f772ffa7 New commit: a0851bcfd Julia version: 1.12.0-DEV Pkg version: 1.12.0 Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@8f772ff...a0851bc ``` $ git log --oneline 8f772ffa7..a0851bcfd a0851bcfd Relax overly-specific manifest tests (JuliaLang#3884) 299b77093 guard against isdir EACESS in completions (JuliaLang#3877) b9c39a7be Merge pull request JuliaLang#3883 from JuliaLang/kc/resolve_tree_hash 8ab562f72 instantiate the test environment if it is in the current workspace when testing 1d961c1c9 get the correct manifest file for a workspace e468facb5 allow `resolve` to download packages that have been deleted from disk but has a manifest entry 20ceec9b8 do not precompile full env on `using` callback from REPL (JuliaLang#3876) 195e17e3f Replace UnstableIO with IOContext{IO} (JuliaLang#3735) 00aa38cb3 add missing `**5.**` (JuliaLang#3870) ac5672dad Revert "Move "Creating Packages" to Julia docs" (JuliaLang#3818) ``` Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of generating llvm globals for all uses of literal_pointer_val (except a few that aren't very important, unless I missed some). we still need to tell dump.c about them before static compilation will work.