Fix inference precision regression for functions returning PartialStruct #38731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the included test case:
```
f_partial_struct_constprop(a, b) = (a[1]+b[1], 2)
g_partial_struct_constprop() = Val{f_partial_struct_constprop((1,), (1,))[1]}()
```
The function `f_partial_struct_constprop` used to infer to `Tuple{Int, Int}`
be eligible for constprop and then get improved to `Const((2,2))`. However,
at some point we sharpened the original inference to `PartialStrict((::Int, 2))`,
which caused an early-out that prevented the consideration of this method
for constant propagation purposes, regressing the overall inference result
to `Tuple{Int, Int}`. Fix that by allowing `PartialStruct` to pass through
the early out. I'm not seeing any impact on inference times.
JeffBezanson
approved these changes
Dec 7, 2020
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 8, 2020
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 9, 2020
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the included test case:
The function
f_partial_struct_constpropused to infer toTuple{Int, Int}be eligible for constprop and then get improved to
Const((2,2)). However,at some point we sharpened the original inference to
PartialStrict((::Int, 2)),which caused an early-out that prevented the consideration of this method
for constant propagation purposes, regressing the overall inference result
to
Tuple{Int, Int}. Fix that by allowingPartialStructto pass throughthe early out. I'm not seeing any impact on inference times.