Qualify function when printing MethodInstance #38608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also print file & line for the case `l.def::Module`. This is already done for stackframes but it is useful to implement it more generally.
timholy
force-pushed
the
teh/show_methinst
branch
from
65f058e
to
8ae50b7
Compare
Sacha0
reviewed
Dec 3, 2020
Sacha0
approved these changes
Dec 3, 2020
|
So, is it better to merge or hold off? I'm fine with either; it's more a question of whether it's better to make as many breaking changes to printing in one release as we can (https://julialang.slack.com/archives/C67TK21LJ/p1607230631257400) or to spread them out. I would go for the former except for the fact that I expect most major packages have already finished dealing with this issue. |
|
Since this has one approval and we've branched for 1.7, let's do it... |
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Dec 9, 2020
timholy
added a commit
to timholy/MethodAnalysis.jl
that referenced
this pull request
Dec 13, 2020
timholy
added a commit
to timholy/MethodAnalysis.jl
that referenced
this pull request
Dec 13, 2020
timholy
added a commit
to timholy/MethodAnalysis.jl
that referenced
this pull request
Dec 13, 2020
timholy
added a commit
to timholy/SnoopCompile.jl
that referenced
this pull request
Dec 13, 2020
Starting with JuliaLang/julia#38608, MethodInstances are printed with module-qualifiers.
timholy
added a commit
to timholy/SnoopCompile.jl
that referenced
this pull request
Dec 13, 2020
Starting with JuliaLang/julia#38608, MethodInstances are printed with module-qualifiers.
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Also print file & line for the case `l.def::Module`. This is already done for stackframes but it is useful to implement it more generally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also print more info for the case
l.def::Module.The module qualification builds off #38596. I've wanted the module-qualifier for a long time, but I recognize it might be bad to add it so close to a release. If desired we can wait until 1.7.