LibGit2: consult known hosts files to verify SSH server identity #38580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the error message for failed TLS host verification to match the error message when SSH host verification fails. The way I've tested this is by changing my
/etc/hosts
file to change the IP address ofgithub.com
and then doing] registry add https://github.com/StefanKarpinski/General.git
and] registry add [email protected]:StefanKarpinski/General.git
. I'm usingarctic1.juliacomputing.io
as my fakegithub.com
server, which works because it's an SSH server (with the wrong identity, of course) and I have a man-in-the-middle HTTPS service that is proxied through togithub.com
setup as well (this is safe since that's the only site it goes through). You can test the case where the host is not in the known hosts file by commenting out the entry forgithub.com
.