Distributed: fix syntax check of environment variable names #38577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previous code accidentally checked `ENV` instead of `env` - now separate `env` checks for POSIX shell and `cmd.exe`, which have quite different format constraints for their environment variable names
|
@musm review/merge requested |
musm
approved these changes
Nov 25, 2020
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
- previous code accidentally checked `ENV` instead of `env` - now separate `env` checks for POSIX shell and `cmd.exe`, which have quite different format constraints for their environment variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous code accidentally checked
ENVinstead ofenvnow separate
envchecks for POSIX shell andcmd.exe, which havequite different format constraints for their environment variable names