Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add a generic code-inferrability test" #38461

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Revert "Add a generic code-inferrability test" #38461

merged 1 commit into from
Nov 16, 2020

Conversation

StefanKarpinski
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski commented Nov 16, 2020 •
edited by vchuravy
Loading

Reverts #37193

x-ref: #38457

vchuravy
vchuravy approved these changes Nov 16, 2020
View reviewed changes
Copy link
Sponsor Member

@vchuravy vchuravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timholy feel free to re-land after the tests are fixed.

@vchuravy
Copy link
Sponsor Member

Ah whole bunch of these jobs failed during the upload to AWS

@vchuravy vchuravy merged commit 9b0232e into master Nov 16, 2020
@vchuravy vchuravy deleted the revert-37193-teh/inference_qa branch November 16, 2020 22:03
@timholy
Copy link
Sponsor Member

timholy commented Nov 16, 2020

I heartily approve, see #38455 (comment). Thanks for doing this.

@timholy timholy mentioned this pull request Nov 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StefanKarpinski @vchuravy @timholy