Fix make test-Test
#38406
Merged
Fix make test-Test
#38406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This testset would fail unless `--depwarn=yes` was set (as it is in process 1). Just run it in its own process that has the commandline flag set appropriately.
c42f
approved these changes
Nov 12, 2020
| end | ||
| incl = "include($(repr(joinpath(@__DIR__, "nothrow_testset.jl"))))" | ||
| cmd = `$(Base.julia_cmd()) --startup-file=no --depwarn=yes -e 'using Test' -e $incl -e $code` | ||
| @test success(pipeline(cmd)) |
There was a problem hiding this comment.
Does pipeline do anything here?
Suggested change
| @test success(pipeline(cmd)) | |
| @test success(cmd) |
| end | ||
| incl = "include($(repr(joinpath(@__DIR__, "nothrow_testset.jl"))))" | ||
| cmd = `$(Base.julia_cmd()) --startup-file=no --depwarn=yes -e 'using Test' -e $incl -e $code` |
There was a problem hiding this comment.
The fact that -e $code works in backticks and is completely safe... 😍
(Yes, I've been bash scripting today)
There was a problem hiding this comment.
I think it can often still be a bit more reliable to put the content into stdin (via pipeline below). But the maximum here is getconf ARG_MAX, or 2MB on linux, 256KB on most posix, and 32k on Windows, and we're very well inside those limits here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testset would fail unless
--depwarn=yeswas set(as it is in process 1). Just run it in its own process
that has the commandline flag set appropriately.