Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for MethodError for cld/fld #38329

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Add test for MethodError for cld/fld #38329

merged 1 commit into from
Nov 9, 2020

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Nov 6, 2020

These two methods are missing tests for this fallback error throw.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Nov 6, 2020
@kshyatt kshyatt requested a review from omus November 6, 2020 17:41
@kshyatt
Copy link
Contributor Author

kshyatt commented Nov 7, 2020

linux32 error is in Profile, linuxaarch64 timed out

@kshyatt kshyatt requested a review from ararslan November 7, 2020 23:23
@kshyatt kshyatt merged commit d562a97 into master Nov 9, 2020
@kshyatt kshyatt deleted the ksh/fldmethoderr branch November 9, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@omus omus Awaiting requested review from omus

@ararslan ararslan Awaiting requested review from ararslan

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshyatt @vchuravy