Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slightly improve inferrability of TOML parser #37813

Merged
merged 1 commit into from
Oct 1, 2020
Merged

slightly improve inferrability of TOML parser #37813

merged 1 commit into from
Oct 1, 2020

Conversation

KristofferC
Copy link
Sponsor Member

#37812 got in a bad state somehow

@KristofferC
Copy link
Sponsor Member Author

KristofferC commented Oct 1, 2020 •
edited
Loading

To be explicit, this avoids the return value (before the conversion from the function signature type assert) to be inferred as Any and now infers to Union{TOMLDict, ParserError}. Having it return Any (and have the signature type assert convert it) means that it is vulnerable to invalidations of convert(::Type{Any}, x).

@KristofferC KristofferC merged commit 2f6508d into master Oct 1, 2020
@KristofferC KristofferC deleted the kc/toml_infer branch October 1, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KristofferC @timholy