Faster implementation of rand(Range1) #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
This is great. As far as I'm concerned you can merge at will. |
lindahua
added a commit
that referenced
this pull request
Jul 21, 2013
Faster implementation of rand(Range1)
| ulen = convert(Uint128, length(r)) | ||
| convert(Int128, first(r) + randu(ulen)) | ||
| end | ||
|
|
There was a problem hiding this comment.
I wish there were a more compact way to write the above three functions without all the duplication. How about convert these to a macro?
There was a problem hiding this comment.
A macro seems like overkill here. Surely there is another way to write it. Maybe randu(unsigned(length(r)))?
|
@ViralBShah I think you mis-labeled this |
|
Thanks. In the labelling spree, this happened a few times and I thought I had fixed all the cases. |
KristofferC
added a commit
that referenced
this pull request
Feb 8, 2024
…53220) Replaces #53216 (I can't push to that repo branch) Adds - making pkgimages for REPLExt - Fixes PkgCompletionProvider location Stdlib: Pkg URL: https://github.com/JuliaLang/Pkg.jl.git Stdlib branch: master Julia branch: master Old commit: f3b81f1aa New commit: 6dd0e7c9e Julia version: 1.11.0-DEV Pkg version: 1.11.0 Bump invoked by: @IanButterworth Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Pkg.jl@f3b81f1...6dd0e7c ``` $ git log --oneline f3b81f1aa..6dd0e7c9e 6dd0e7c9e Revert "add test for recurring precompile" (#3779) dbf114fa9 Merge pull request #3777 from JuliaLang/kc/repl_extension a49d47981 fixup e3edf3917 avoid prompting for git creds on CI (#3778) 510454343 make the `REPL` specific code into an extension 12d2de14e make `pkgstr` independent of REPL ``` --------- Co-authored-by: Dilum Aluthge <[email protected]> Co-authored-by: Valentin Churavy <[email protected]> Co-authored-by: Kristoffer Carlsson <[email protected]> Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster & simpler implementation of rand(Range1), and it strictly guarantees equal probabilities of choosing each integer within the range.
My benchmark shows that it is about 1.7x - 2.1x faster than the original implementation.