Fix escaped % printing in new Printf code #37785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #37784. The classic blunder of not unescaping the escaped when printing. I considered trying to detect escaped chars during format construction-time, but there isn't a clean way to utilize the current `Printf.Format` structure to achieve this, since it requires `length(f.formats) == length(f.substringranges) + 1`, and `f.substringranges` must be the concretely typed `Vector{UnitRange{Int}}`. Doing the unescaping in `Printf.format` when we're outputting seems to not incur any performance penalty and seems like a pretty clean fix since all outputting is handled in this one function anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37784. The classic blunder of not unescaping the escaped when
printing. I considered trying to detect escaped chars during format
construction-time, but there isn't a clean way to utilize the current
Printf.Formatstructure to achieve this, since it requireslength(f.formats) == length(f.substringranges) + 1, andf.substringrangesmust be the concretely typedVector{UnitRange{Int}}. Doing the unescaping inPrintf.formatwhenwe're outputting seems to not incur any performance penalty and seems
like a pretty clean fix since all outputting is handled in this one
function anyway.